[SPARK-27744][SQL] preserve spark properties on async subquery tasks #24625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gatorsmile curious to hear your thoughts about this |
|
friendly ping @gatorsmile |
|
friendly ping @gatorsmile |
|
ok to test |
|
Test build #106204 has finished for PR 24625 at commit
|
|
@gatorsmile do you have any comments? should I tag anyone else for review? thanks! |
|
friendly ping on above @gatorsmile |
bulldozer-bot bot
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 20, 2019
## Upstream SPARK-XXXXX ticket and PR link (if not applicable, explain) https://issues.apache.org/jira/browse/SPARK-27744 apache#24625 ## What changes were proposed in this pull request? preserve spark properties on subquery exec tasks ## How was this patch tested? unit tests
|
friendly ping on above @gatorsmile |
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. If you'd like to revive this PR, please reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new future helper method that copies over spark properties before submitting to a new thread, and sets the original properties back on exit. SubqueryExec now uses this method to create futures. Any task that is submitted to its thread pool will now use the spark properties of the submitting thread, instead of the spark properties that were on the thread pool worker thread
How was this patch tested?
Added a test, which fails with current master but passes with this patch